Closed
Conversation
ttnghia
added
3 - Ready for Review
bdice
requested changes
Jul 6, 2022
Contributor
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
See issue #7960. I would support an updated version strictly for bug fixes in Google Benchmark that affect our workflows and performance measurements, but if new features are required for new benchmarks (it is mentioned that this blocks #11202), we should instead invest effort in transitioning to nvbench.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of Google benchmark is 1.5.2, which was released nearly 2 years ago. The latest version has many new useful APIs that we should use. For example,
benchmark::CreateRangethat allows creating ranges which can be used inside theArgsProduct()function.This PR update cudf cmake to use the latest Google benchmark version (v1.6.1).
Blocks #11202.